UBI: fix a horrible memory deallocation bug

http://git.kernel.org/?p=linux/k ... 4ed3beeffbbff869285linux kernel 3.5.4 修复 UBI 内存释放的严重 BUG

1. diff --git a/drivers/mtd/ubi/vtbl.c b/drivers/mtd/ubi/vtbl.c
   
2. index 437bc19..568307c 100644 (file)
   
3. --- a/drivers/mtd/ubi/vtbl.c
   
4. +++ b/drivers/mtd/ubi/vtbl.c
   
5. @@ -340,7 +340,7 @@ retry:
   
6.          * of this LEB as it will be deleted and freed in 'ubi_add_to_av()'.
   
7.          */
   
8.         err = ubi_add_to_av(ubi, ai, new_aeb->pnum, new_aeb->ec, vid_hdr, 0);
   
9. -       kfree(new_aeb);
   
10. +       kmem_cache_free(ai->aeb_slab_cache, new_aeb);
    
11.         ubi_free_vid_hdr(ubi, vid_hdr);
    
12.         return err;
    
13. 
    
14. @@ -353,7 +353,7 @@ write_error:
    
15.                 list_add(&new_aeb->u.list, &ai->erase);
    
16.                 goto retry;
    
17.         }
    
18. -       kfree(new_aeb);
    
19. +       kmem_cache_free(ai->aeb_slab_cache, new_aeb);
    
20. out_free:
    
21.         ubi_free_vid_hdr(ubi, vid_hdr);
    
22.         return err;
    

复制代码

多谢提醒！